GH-10058: Add Jackson 3 ObjectMapper and MessageParser #10160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthologia
commented
Jun 23, 2025
...re/src/main/java/org/springframework/integration/support/json/Jackson3JsonMessageParser.java
Outdated
Show resolved
Hide resolved
artembilan
requested changes
Jun 24, 2025
There was a problem hiding this comment.
Thank you!
This is great start!
Any chances to have some tests on the matter?
Especially I'm interested in those loaded by the Jackson 3 modules if we remove our custom collectWellKnownModulesIfAvailable().
Re. defaults in v3 VS v2: I have raised concern with the team.
Will come back to ASAP.
...re/src/main/java/org/springframework/integration/support/json/Jackson3JsonMessageParser.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/org/springframework/integration/support/json/Jackson3JsonObjectMapper.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/springframework/integration/support/json/Jackson3JsonMessageParser.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/org/springframework/integration/support/json/Jackson3JsonObjectMapper.java
Outdated
Show resolved
Hide resolved
artembilan
requested changes
Jun 25, 2025
...ore/src/main/java/org/springframework/integration/support/json/Jackson3JsonObjectMapper.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/springframework/integration/support/json/Jackson3JsonMessageParser.java
Outdated
Show resolved
Hide resolved
anthologia
force-pushed
the
GH-10058
branch
2 times, most recently
from
ad80fa8 to
76984b1
Compare
artembilan
requested changes
Jun 26, 2025
...core/src/main/java/org/springframework/integration/support/json/JacksonJsonObjectMapper.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/org/springframework/integration/support/json/JsonObjectMapperProvider.java
Show resolved
Hide resolved
.../src/test/java/org/springframework/integration/support/json/JacksonJsonObjectMapperTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/springframework/integration/support/json/JacksonJsonObjectMapperTest.java
Outdated
Show resolved
Hide resolved
Related to: spring-projects#10058 * Add Jackson3JsonObjectMapper, Jackson3JsonMessageParser to prepare for Jackson 2 to 3 migration. Signed-off-by: Jooyoung Pyoung <[email protected]>
* Rename `Jackson3JsonObjectMapper` to `JacksonJsonObjectMapper` * Rename `Jackson3JsonMessageParser` to `JacksonJsonMessageParser` * Wrap `JacksonException` in `IOException` to maintain API contract * Replace manual module collection with `findAndAddModules()` Signed-off-by: Jooyoung Pyoung <[email protected]>
Signed-off-by: Jooyoung Pyoung <[email protected]>
* Add try-catch for valueToTree() call * Remove conditional module checks in tests * Update jsonAvailable() to check Jackson 3 Signed-off-by: Jooyoung Pyoung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #10058
Jackson3JsonObjectMapper,Jackson3JsonMessageParserto prepare for Jackson 2 to 3 migration (Work3).Jackson 3 Exception Model Changes
Jackson 3 changed its exception hierarchy from checked to unchecked.
Now,
JacksonExceptionextendsRuntimeExceptionnotIOException.Jackson 3 default setting changes
Jackson 3.0 has different default settings compared to 2.x that may affect serialization behavior.
For example, these timestamp-related settings have changed:
WRITE_DATES_AS_TIMESTAMPS(false)// was true in 2.xWRITE_DURATIONS_AS_TIMESTAMPS(false)// was true in 2.xONE_BASED_MONTHS(true)// was false in 2.xShould we maintain Jackson 2.x compatibility, or adopt Jackson 3 defaults?